GH-47389: [Python] CSV and JSON options lack a nice repr/str - #47397
Merged
Conversation
github-actions
Bot
added
Component: Python
awaiting committer review
thisisnic
marked this pull request as ready for review
August 25, 2025 13:48
AlenkaF
reviewed
Sep 1, 2025
AlenkaF
left a comment
AlenkaF
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this @thisisnic!
My first thought was whether we could simplify this to avoid hardcoding all the options, but nothing simpler comes to mind — I don't think we can easily loop over attributes in a Cython cdef class.
So overall, no big concerns — just one note about a missing option and a small nit.
github-actions
Bot
added
awaiting changes
AlenkaF
reviewed
Sep 2, 2025
AlenkaF
left a comment
AlenkaF
left a comment
Member
There was a problem hiding this comment.
Thanks for the changes! Two more comments from me.
AlenkaF
force-pushed
the
GH-47359_repr_str_csv_json
branch
from
October 23, 2025 17:09
b1177bc to
2b3354b
Compare
AlenkaF
approved these changes
Oct 24, 2025
Member
|
@pitrou mind having a quick look? |
pitrou
reviewed
Oct 28, 2025
thisisnic
force-pushed
the
GH-47359_repr_str_csv_json
branch
from
March 11, 2026 04:46
fdcdefe to
82dc9ad
Compare
github-actions
Bot
added
awaiting changes
Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com>
thisisnic
force-pushed
the
GH-47359_repr_str_csv_json
branch
from
March 17, 2026 10:06
82dc9ad to
552771e
Compare
github-actions
Bot
added
awaiting change review
Member
|
Thanks for the changes @thisisnic! |
Member
|
Thanks @thisisnic ! |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 618d5fb. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
added a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
…pache#47397) ### Rationale for this change CSV and JSON options lack a nice repr/str dunder method ### What changes are included in this PR? Add both these methods ### Are these changes tested? Will be once it's ready for review ### Are there any user-facing changes? No * GitHub Issue: apache#47389 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…pache#47397) ### Rationale for this change CSV and JSON options lack a nice repr/str dunder method ### What changes are included in this PR? Add both these methods ### Are these changes tested? Will be once it's ready for review ### Are there any user-facing changes? No * GitHub Issue: apache#47389 Lead-authored-by: Nic Crane <thisisnic@gmail.com> Co-authored-by: AlenkaF <frim.alenka@gmail.com> Co-authored-by: Alenka Frim <AlenkaF@users.noreply.github.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
CSV and JSON options lack a nice repr/str dunder method
What changes are included in this PR?
Add both these methods
Are these changes tested?
Will be once it's ready for review
Are there any user-facing changes?
No